You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"Insufficient balance to reverse position after hitting stop loss, closing position with stop loss order."
)
self.execute_stop_loss()
Return after stop-loss fallback in reversal path
With the new <= check, insufficient-balance cases now enter this branch, call execute_stop_loss(), and then continue into new-bot creation and reversal orders. In this flow, _is_reversal_possible(...) returns current_contracts when reversal is not affordable, so continuing after stop-loss can still submit unintended reversal orders immediately after closing, which contradicts the fallback message and can produce extra trades/fees in live futures accounts.
This equality heuristic (abs(lastBenchmarkValue - latestPortfolioValue) < 0.0001) is brittle now that the backend appends a live point per benchmark request: when /balance and /benchmark-series are fetched at slightly different times, small market moves frequently make the values differ by more than the threshold. In that case, previousPortfolioValue falls back to the last benchmark value (another live sample) instead of the prior stored snapshot, so displayed PnL becomes near-zero/noisy rather than reflecting the intended last-snapshot delta.
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.